[PATCH] D53554: [Argument Promotion] Only promote args when function attributes are compatible

[Tom Stellard via Phabricator via llvm-commits]

tstellar updated this revision to Diff 177999.
tstellar added a comment.

Some small updates:

+ Clarified Comment
+ Decoupled new function from areInlineCompatible()

Questions I have still:

+ I'm still a little confused by the layering of TTI.  I tried to move the
implementation out of TargetTransformInfoImplBase and into BasicTTI, but
that breaks the NoTTIImpl class.

+ Do we need a separate function byval and normal args?  I thought that information
was accessible via the Argument objects that are passed to the function.

+ Is it possible to implement a generic version of this function for simple argument
types without any target-specifc knowledge?  Does LLVM IR guarantee anything about
calling convention for simple types?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53554/new/

https://reviews.llvm.org/D53554

Files:
  include/llvm/Analysis/TargetTransformInfo.h
  include/llvm/Analysis/TargetTransformInfoImpl.h
  lib/Analysis/TargetTransformInfo.cpp
  lib/Transforms/IPO/ArgumentPromotion.cpp
  test/Transforms/ArgumentPromotion/X86/attributes.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53554.177999.patch
Type: text/x-patch
Size: 9977 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181213/7f65c53c/attachment.bin>