[PATCH] D55617: [gn build] Fix defines define on Windows

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 12 16:03:31 PST 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL348993: [gn build] Fix defines define on Windows (authored by smeenai, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D55617?vs=177912&id=177967#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55617/new/

https://reviews.llvm.org/D55617

Files:
  llvm/trunk/utils/gn/build/BUILD.gn


Index: llvm/trunk/utils/gn/build/BUILD.gn
===================================================================
--- llvm/trunk/utils/gn/build/BUILD.gn
+++ llvm/trunk/utils/gn/build/BUILD.gn
@@ -3,9 +3,11 @@
 import("//llvm/utils/gn/build/toolchain/compiler.gni")
 
 config("compiler_defaults") {
+  defines = []
+
   # FIXME: Don't define this globally here.
   if (host_os != "win") {
-    defines = [ "LLVM_ON_UNIX" ]
+    defines += [ "LLVM_ON_UNIX" ]
   }
 
   if (!llvm_enable_assertions) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55617.177967.patch
Type: text/x-patch
Size: 494 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181213/65500e27/attachment.bin>


More information about the llvm-commits mailing list