[PATCH] D55624: Windows rename_internal function incorrectly passing character count instead of byte count to SetFileInformationByHandle.

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 12 15:56:24 PST 2018


smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

That's the intent ... it uploads the entire file to Phabricator, so that it can be viewed through the web interface. The arcanist tool does that for you automatically, as an alternative to have to copy and paste a giant block of text around.

In this case, I just looked at the surrounding context myself, and this LGTM. Do you need someone to commit this? Context will be helpful for future patches though.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55624/new/

https://reviews.llvm.org/D55624





More information about the llvm-commits mailing list