[PATCH] D55624: Windows rename_internal function incorrectly passing character count instead of byte count to SetFileInformationByHandle.
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 12 15:22:27 PST 2018
smeenai added reviewers: compnerd, rnk.
smeenai added a comment.
This LGTM, but before I approve, I'd like to look around the surrounding code to confirm things are how I expect, but this patch is uploaded without context :( Could you reupload with context? See https://llvm.org/docs/Phabricator.html (the part about using `-U999999` in your git commands to generate full context).
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55624/new/
https://reviews.llvm.org/D55624
More information about the llvm-commits
mailing list