[PATCH] D55612: [macho] save the SDK version stored in module metadata into the version min and build version load commands in the object file

Alex Lorenz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 12 15:11:11 PST 2018


arphaman added a comment.

In D55612#1328773 <https://reviews.llvm.org/D55612#1328773>, @steven_wu wrote:

> Don't we need IR support for this as well? sdk version is not in the triple so it is going to get lost when building from IR. Maybe use a metadata node?


I provide a way to set and retrieve the SDK version from the IR using the "SDK Version" metadata. Do I need something more than that? Clang can set it and we are already getting it in this patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55612/new/

https://reviews.llvm.org/D55612





More information about the llvm-commits mailing list