[PATCH] D55621: [asan] Don't check ODR violations for particular types of globals

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka created this revision.
vitalybuka added reviewers: eugenis, kcc.
Herald added subscribers: hiraditya, kubamracek.

private and internal: should not trigger ODR at all.
unnamed_addr: current ODR checking approach fail and rereport false violation if
a linker merges such globals
linkonce_odr, weak_odr: could cause similar problems and they are already not
instrumented for ELF.


Repository:
  rL LLVM

https://reviews.llvm.org/D55621

Files:
  clang/test/CodeGen/asan-static-odr.cpp
  compiler-rt/lib/asan/asan_globals.cc
  compiler-rt/test/asan/TestCases/Linux/odr_indicators.cc
  llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
  llvm/test/Instrumentation/AddressSanitizer/do-not-touch-odr-global.ll
  llvm/test/Instrumentation/AddressSanitizer/global_metadata.ll
  llvm/test/Instrumentation/AddressSanitizer/local_alias.ll
  llvm/test/Instrumentation/AddressSanitizer/odr-check-ignore.ll
  llvm/test/Instrumentation/AddressSanitizer/win-string-literal.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55621.177928.patch
Type: text/x-patch
Size: 10727 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181212/f23c687e/attachment.bin>