[PATCH] D55605: [NewPM] Port Msan: Alternative approach using a module to create the global constructor

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1077
   Value *updateOrigin(Value *V, IRBuilder<> &IRB) {
-    if (MS.TrackOrigins <= 1) return V;
+    if (MS.MSanOptions.TrackOrigins <= 1)
+      return V;
----------------
While generally sympathetic to desire for organization of assorted booleans into a MSanOptions struct,
seeing how 86% of this patch is just a replacement of MS.* with MS.MSanOptions.* I would rather like
to see it come separately (as a preceeding, or perhaps followup, NFC refactoring).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55605/new/

https://reviews.llvm.org/D55605