[PATCH] D55449: [InstCombine] Fix negative GEP offset evaluation for 32-bit pointers

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 12 13:55:50 PST 2018


nikic added a comment.

I went with the SignExtend64 approach you suggested. Looking at the code directly above (for the zero offset case), it even explicitly inserts a truncate into IR, so it seems appropriate to just follow suit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55449/new/

https://reviews.llvm.org/D55449





More information about the llvm-commits mailing list