[PATCH] D55449: [InstCombine] Fix negative GEP offset evaluation for 32-bit pointers

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 12 12:59:28 PST 2018


efriedma added a comment.

Checking for overflow would also be fine, but I think you would want to check overflow on each operation that modifies the offset, as opposed to the final result (which might have overflowed the 64-bit integer anyway).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55449/new/

https://reviews.llvm.org/D55449





More information about the llvm-commits mailing list