[PATCH] D55611: Rename GISelChangeObserver's erasedInstr() to erasingInstr() and related nits. NFC

[Daniel Sanders via Phabricator via llvm-commits]

dsanders created this revision.
dsanders added a reviewer: aditya_nandakumar.

There's little of interest that can be done to an already-erased instruction.
You can't inspect it, write it to a debug log, etc. It ought to be notification
that we're about to erase it. Rename the function to clarify the timing of the
event and reflect current usage.

Also fixed one case where we were trying to print an erased instruction.


Repository:
  rL LLVM

https://reviews.llvm.org/D55611

Files:
  include/llvm/CodeGen/GlobalISel/CombinerHelper.h
  include/llvm/CodeGen/GlobalISel/GISelChangeObserver.h
  lib/CodeGen/GlobalISel/Combiner.cpp
  lib/CodeGen/GlobalISel/CombinerHelper.cpp
  lib/CodeGen/GlobalISel/Legalizer.cpp
  unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55611.177894.patch
Type: text/x-patch
Size: 5157 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181212/8d30a5eb/attachment.bin>