[PATCH] D55449: [InstCombine] Fix negative GEP offset evaluation for 32-bit pointers

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 12 12:32:00 PST 2018


efriedma added a comment.

I think I would rather SignExtend64(X, 32) or something like that... yes, it's effectively the same for well-defined code, but I'd rather explicitly truncate the offset rather than implicitly truncate it in ConstantInt::get.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55449/new/

https://reviews.llvm.org/D55449





More information about the llvm-commits mailing list