[PATCH] D52999: [FileCheck] Annotate input dump (1/7)
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 12 11:50:22 PST 2018
probinson added inline comments.
================
Comment at: llvm/include/llvm/Support/FileCheck.h:162
+ // TODO: More members will appear with later patches in this series.
+ /// no match for an expected pattern
+ MatchNoneButExpected,
----------------
jdenny wrote:
> probinson wrote:
> > Comments should be proper sentences.
> Thanks. Before I adjust all the patches, does the following work, or was this more than a style issue?
>
> ```
> /// Indicates no match for an expected pattern.
> ```
>
>
>
Just style. What you propose is fine.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52999/new/
https://reviews.llvm.org/D52999
More information about the llvm-commits
mailing list