[PATCH] D55606: [gn build] Add infrastructure to create symlinks and use it to create lld's symlinks

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: llvm/utils/gn/build/symlink_or_copy.py:3
+
+"""Symlinks, or on Windows copies, an existing file to a second location.
+
----------------
Starting with Windows 10 RS2 (version 1703, released April 2017), you can create symlinks without needing to elevate to administrator if you have developer mode configured. I would imagine that's a reasonably common configuration for LLVM devs, and the symlinks end up saving a bunch of space. Do you think it's worth considering (not necessarily as a part of this patch; it could be done later) attempting to create a symlink even on Windows, and falling back to a copy if you get a permission denied error? I've been meaning to implement something similar on the CMake side.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55606/new/

https://reviews.llvm.org/D55606