[PATCH] D53896: [FileCheck] Annotate input dump (4/7)

Wed Dec 12 11:00:19 PST 2018

probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

These get to be pretty mechanical after a while, don't they?  I was wondering how hard it would be for someone else, next time somebody wants to add a new directive kind, but it seems like not really a big deal and that's a good thing.
Again a comment needs fixing but otherwise LGTM.
I'll try to get to the rest tomorrow.

================
Comment at: llvm/include/llvm/Support/FileCheck.h:167
     // TODO: More members will appear with later patches in this series.
+    /// the final match for an excluded pattern
+    MatchFinalButExcluded,
----------------
Comments should be proper sentences.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53896/new/

https://reviews.llvm.org/D53896