[PATCH] D55430: build.py: Implement "gcc" builder

Wed Dec 12 08:52:39 PST 2018

labath marked an inline comment as done.
labath added inline comments.

================
Comment at: lldb/trunk/lit/helper/build.py:630
+            args.append('-nostdinc')
+            args.append('-static')
+        args.append('-c')
----------------
zturner wrote:
> Why do we need this?
Without this I got errors when trying this out on a mac (something about "dynamically linked executables must link to libSystem.dylib"). Doing a static link in this case did not seem like a bad choice, since this script doesn't even support building shared libraries at this point. If we get to a point where we want to build shared libraries in --nodefaultlib mode, then we will have to revisit this.

(this could be made darwin-only, but it seemed better to be consistent).

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55430/new/

https://reviews.llvm.org/D55430