[PATCH] D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path.

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

As a starting point, this sure looks good to me. Thanks!



================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:6980
+  // code. Masked vector code generation support will follow soon.
+  if (VPlanBuildStressTest || EnableVPlanPredication)
     return false;
----------------
Do you have an RFC or review on the code generation part? It would be good to have an idea soon enough.


================
Comment at: lib/Transforms/Vectorize/VPlanPredicator.cpp:198
+
+  // TODO: Handle nested regions
+}
----------------
Shouldn't this be more like an assert, as if you don't handle nested regions, you can't get the full predication for the dominators and codegen will fail, no?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53349/new/

https://reviews.llvm.org/D53349