[PATCH] D54924: [WebAssembly] Check if the section order is correct
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 11 21:42:48 PST 2018
aheejin marked an inline comment as done.
aheejin added inline comments.
================
Comment at: include/llvm/Object/Wasm.h:311
+ // Must come after "linking" section in order to validate reloc indexes.
+ WASM_SEC_ORDER_RELOC = 101,
+ // "name" section must appear after DATA. Comes after "linking" to allow
----------------
aheejin wrote:
> I copied this comments on orders (linking section should be after data section and reloc sections should be after linking section) from D44024. Are these still valid? If so, do you think we should specify them in [Linking spec](https://github.com/WebAssembly/tool-conventions/blob/master/Linking.md)?
Oh after deleting some code the comment location got weird. What I meant was the comments about relationship of data - "reloc" and "reloc" - "linking".
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54924/new/
https://reviews.llvm.org/D54924
More information about the llvm-commits
mailing list