[PATCH] D55352: [elfabi] Introduce tool for ELF TextAPI

[Armando Montanez via Phabricator via llvm-commits]

amontanez marked 2 inline comments as done.
amontanez added inline comments.


================
Comment at: llvm/tools/llvm-elfabi/ErrorCollector.cpp:36
+  log(RawSS);
+  UnhandledErrIdx = Errors.size();
+  return createStringError(errc::interrupted, RawSS.str().c_str());
----------------
jakehehrlich wrote:
> Rather than this, when you make the error you should be left with an empty vector of errors. Long term I'd like to see this be a move of the vector into an aggregate error but for now I'm fine just consuming and clearing.
Agreed. I marked TODO at the top of this function since that's something that can be done later when it's slightly higher priority.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55352/new/

https://reviews.llvm.org/D55352