[PATCH] D55547: [ConstantInt] Check active bits before calling getZExtValue.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 11 18:33:30 PST 2018
fhahn added a comment.
In D55547#1327337 <https://reviews.llvm.org/D55547#1327337>, @efriedma wrote:
> LGTM; arrays/struct types are currently limited to 2^64 elements anyway.
>
> > should we update getAggregateElement to take an uin64_t as well?
>
> Yes, all the ConstantAggregate-related code should use uint64_t to match the type system. See also https://reviews.llvm.org/D55169, where this just came up.
Thanks Eli, I'll see if I can put together a follow-up patch in the next few days.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55547/new/
https://reviews.llvm.org/D55547
More information about the llvm-commits
mailing list