[PATCH] D53927: [AArch64] Enable libm vectorized functions via SLEEF

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: llvm/trunk/lib/Analysis/TargetLibraryInfo.cpp:29
+                          "Intel SVML library"),
+               clEnumValN(TargetLibraryInfoImpl::SLEEFGNUABI, "sleefgnuabi",
+                          "SIMD Library for Evaluating Elementary Functions")));
----------------
fpetrogalli wrote:
> rengolin wrote:
> > A quick google search told me GCC uses `-fveclib=SLEEF`. We don't want to be different or that would create big problems in build systems. It seems, at least right now, there's only one ABI, so there's no point in premature classification.
> Hi @rengolin  - where did you find this option? I am struggling to find it in the gcc code base and in the gcc developer mailing lists. GCC uses -mveclibabi, but it is only for x86.
Hum, now I'm struggling to find it, too. I may have hit a sweet spot between `sleef` from clang and `mveclibabi` from gcc and assumed it worked.

This page [1] tells me only `svml` and `acml` are supported, so I stand corrected. However, if/when gcc supports it, `mveclibabi=sleefgnuabi` will be very weird. So I still prefer `sleef` instead of `sleefgnuabi`.

Also, why do we use `fveclib` and not `mveclibabi`? This isn't really helpful for build systems...

[1] https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53927/new/

https://reviews.llvm.org/D53927