[PATCH] D55560: [RISCV] Attach VK_RISCV_CALL to symbols upon creation

[Lewis Revill via Phabricator via llvm-commits]

lewis-revill added inline comments.


================
Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:280
+    return RISCVAsmParser::classifySymbolRef(getImm(), VK, Imm) &&
+           (VK == RISCVMCExpr::VK_RISCV_None ||
+            VK == RISCVMCExpr::VK_RISCV_CALL);
----------------
jrtc27 wrote:
> I don't think we want to allow `VK_RISCV_None`, as `expandFunctionCall` won't add a `VK_RISCV_CALL` wrapper so we won't get an `R_RISCV_CALL`?
Good catch, I'll fix that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55560/new/

https://reviews.llvm.org/D55560