[PATCH] D54337: [ASan] Make AddressSanitizer a ModulePass

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added a comment.

> Analysis can be any information which is not an IR itself. TargetLibraryInfo, DominatorTree, GlobalsMetadata... whatever.
>  The only problem that you might find when using your custom analysis from the pass will be similar to the current dichotomy of module & function ASan.
>  You can not *run* module analysis from within a function pass. It can only be run on a module level.

Hmm. So if we keep ASan as a function pass, there doesn't seem to be a clean already existing way of performing one task before pass runs, especially if a pass for one IR unit cannot depend on/require running a pass on a different IR unit type first.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54337/new/

https://reviews.llvm.org/D54337