[PATCH] D54507: [ThinLTO] Handle chains of aliases

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/IR/Value.cpp:469
+  // Strip off pointer casts, all-constant inbounds GEPs, and aliases.
+  PSK_InBoundsConstantIndicesAndAliases,
+  // Strip off pointer casts, inbounds GEPs, and aliases.
----------------
Perhaps there is no need to change the name of this kind -- proper documentation is probably enough.


================
Comment at: lib/IR/Value.cpp:471
+  // Strip off pointer casts, inbounds GEPs, and aliases.
+  PSK_InBoundsAndAliases,
+  // Strip off pointer casts and inbounds GEPs.
----------------
Name the new one PSK_InBoundsNoAliases so that existing enumerator's semantics do not change.


================
Comment at: lib/IR/Value.cpp:473
+  // Strip off pointer casts and inbounds GEPs.
   PSK_InBounds
 };
----------------
Perhaps leave the semantics of this enum unchanged?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54507/new/

https://reviews.llvm.org/D54507