[PATCH] D54507: [ThinLTO] Handle chains of aliases

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:427
 
 inline GlobalValueSummary *GlobalValueSummary::getBaseObject() {
+  auto *S = this;
----------------
Can  this be refactored as

 return const_cast<const GlobalValueSummary *>(this)->getBaseObject();

to avoid code duplication?


================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:446
 
+static void finalizeAliasSummary(ModuleSummaryIndex &Index,
+                                 const GlobalAlias &A) {
----------------
Add a comment for the function?


================
Comment at: lib/IR/Value.cpp:475
+  PSK_InBoundsConstantIndicesAndAliases,
+  PSK_InBoundsAndAliases,
   PSK_InBounds
----------------
Add some documentation on the InBounds kinds?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54507/new/

https://reviews.llvm.org/D54507