[PATCH] D55564: [lit]Add llvm-readelf to tool substitutions

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: courbet, gchatelet, lebedev.ri, rnk, alexshap.
Herald added a subscriber: llvm-commits.

llvm-readelf was missing from the list of tool substitutions in the lit configuration. This caused no functional issue, because the tools directory is also added to the PATH (why do we do both?), but it did mean that the lit output didn't provide the full path to the llvm-readelf executable, which is useful for rerunning the command outside the test.


Repository:
  rL LLVM

https://reviews.llvm.org/D55564

Files:
  test/lit.cfg.py


Index: test/lit.cfg.py
===================================================================
--- test/lit.cfg.py
+++ test/lit.cfg.py
@@ -146,11 +146,11 @@
     'llvm-isel-fuzzer', 'llvm-opt-fuzzer', 'llvm-lib', 'llvm-link', 'llvm-lto',
     'llvm-lto2', 'llvm-mc', 'llvm-mca', 'llvm-modextract', 'llvm-nm',
     'llvm-objcopy', 'llvm-objdump', 'llvm-pdbutil', 'llvm-profdata',
-    'llvm-ranlib', 'llvm-readobj', 'llvm-rtdyld', 'llvm-size', 'llvm-split',
-    'llvm-strings', 'llvm-strip', 'llvm-tblgen', 'llvm-undname', 'llvm-c-test',
-    'llvm-cxxfilt', 'llvm-xray', 'yaml2obj', 'obj2yaml', 'yaml-bench',
-    'verify-uselistorder', 'bugpoint', 'llc', 'llvm-symbolizer', 'opt',
-    'sancov', 'sanstats'])
+    'llvm-ranlib', 'llvm-readelf', 'llvm-readobj', 'llvm-rtdyld', 'llvm-size',
+    'llvm-split', 'llvm-strings', 'llvm-strip', 'llvm-tblgen', 'llvm-undname',
+    'llvm-c-test', 'llvm-cxxfilt', 'llvm-xray', 'yaml2obj', 'obj2yaml',
+    'yaml-bench', 'verify-uselistorder', 'bugpoint', 'llc', 'llvm-symbolizer',
+    'opt', 'sancov', 'sanstats'])
 
 # The following tools are optional
 tools.extend([


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55564.177702.patch
Type: text/x-patch
Size: 1109 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181211/bfcc935f/attachment.bin>