[PATCH] D55555: [LLD][ELF][ARM] Add support for architecture v6m thunks

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

I do not know enough about arm to give a sign-off, but the code looks good to me. A minor nit is below.



================
Comment at: ELF/Thunks.cpp:787
     else
-      // The Armv6-m architecture (Cortex-M0) does not have Arm instructions or
-      // support the MOVT MOVW instructions so it cannot use any of the Thunks
-      // currently implemented.
-      fatal("thunks not supported for architecture Armv6-m");
+      return addThunkV6M(Reloc, S);
   }
----------------
You do not need `else` after return.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55555/new/

https://reviews.llvm.org/D55555