[PATCH] D54740: [NewPM] fixing asserts on deleted loop in -print-after-all

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 11 04:10:13 PST 2018


fedor.sergeev added a comment.

In D54740#1326165 <https://reviews.llvm.org/D54740#1326165>, @philip.pfaffe wrote:

> The invalid handle isn't good for accessing anything, but it can still //identify// a unit.


Not really. If you say have a Loop* pointer, which is freed and then another Loop allocated happens to be just at that pointer
then you dont have a way to identify whether it is the old Loop or the new one.
Presumably that does not happen now...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54740/new/

https://reviews.llvm.org/D54740





More information about the llvm-commits mailing list