[PATCH] D55550: [LLD][ELF] - Fix the different behavior of the linker script symbols on different platforms.

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 11 03:52:07 PST 2018


peter.smith added a comment.

Overall I'm happy with this change as I think it is simpler than adding another call to Writer<ELFT>::run(). The one remaining thought is whether Writer<ELFT>::run() can be moved into finalizeAddressDependentContent() as there shouldn't be anything after that function that changes address. Could we move the remaining Writer<ELFT>::run() to the end of finalizeAddressDependentContent() ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55550/new/

https://reviews.llvm.org/D55550





More information about the llvm-commits mailing list