[PATCH] D55524: [gn build] Add build files for Target/X86/... and for tools/llc
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 11 03:14:45 PST 2018
thakis marked an inline comment as done.
thakis added inline comments.
================
Comment at: llvm/utils/gn/secondary/llvm/lib/Target/targets.gni:11
llvm_targets_to_build = [ "X86" ]
- } else if (host_cpu == "arm") {
- llvm_targets_to_build = [ "ARM" ]
- } else if (host_cpu == "arm64") {
- llvm_targets_to_build = [ "AArch64" ]
+ #} else if (host_cpu == "arm") {
+ #llvm_targets_to_build = [ "ARM" ]
----------------
phosek wrote:
> Is this intentional? If yes, can you comment on why is arm32 and arm64 being disabled?
Yes, it's because lib/Target/BUILD.gn now use llvm_targets_to_build to set up forwarding targets but lib/Target/ARM/BUILD.gn and lib/Target/AArch64/BUILD.gn don't exist yet. When I add them I'm going to add these back. It's hopefully just commented out for a few days.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55524/new/
https://reviews.llvm.org/D55524
More information about the llvm-commits
mailing list