[PATCH] D55279: [RISCV] Support assembling %got_pcrel_hi operator

Tue Dec 11 02:49:47 PST 2018

jrtc27 added a comment.

In D55279#1326559 <https://reviews.llvm.org/D55279#1326559>, @lewis-revill wrote:

> In D55279#1326556 <https://reviews.llvm.org/D55279#1326556>, @lewis-revill wrote:
>
> > Do you need to add a check for `RISCV::fixup_riscv_pcrel_hi20` in `getPcRelHiExpr`? Currently this is returning null and causing a segfault when running your `relocations.s` tests.
>
>
> `RISCV::fixup_riscv_pcrel_hi20` ->`RISCV::fixup_riscv_got_hi20`

Yes, but in D54029 <https://reviews.llvm.org/D54029> I had asked that check to be included (I just patched D54029 <https://reviews.llvm.org/D54029> locally). With the latest version of that revision, though, it's going to print out an error about not being able to find the corresponding HI relocation so needs some further changes.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55279/new/

https://reviews.llvm.org/D55279