[PATCH] D55160: [coroutines] Improve suspend point simplification

[Gor Nishanov via Phabricator via llvm-commits]

GorNishanov marked 4 inline comments as done.
GorNishanov added inline comments.


================
Comment at: lib/Transforms/Coroutines/CoroSplit.cpp:566
+  // will have to eventually hit SaveBB when going backwards from ResDesBB.
+  while (Worklist.empty()) {
+    auto *BB = Worklist.pop_back_val();
----------------
modocache wrote:
> Is this condition inverted because of a typo? I'd expect this to be `while (!Worklist.empty()) { ... }`.
Good catch. My tests were not catching it because they were too blunt, running entire -O2 pipeline as opposed to just coro-split pass.

Now, tests are running just coro-split pass and caught this mistake too which is fixed now.

Thank you for catching it!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55160/new/

https://reviews.llvm.org/D55160