[PATCH] D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added a comment.

In D53540#1326353 <https://reviews.llvm.org/D53540#1326353>, @TomTan wrote:

> In D53540#1326343 <https://reviews.llvm.org/D53540#1326343>, @mgrang wrote:
>
> > @dmajor My updated change fixes the crash in your testcase.
> >
> > Now, I am trying to build the SEH tests released by MS: https://github.com/Microsoft/windows_seh_tests. I started with XCPT4 tests. test5 is currently failing which I am triaging now.
>
>
> @mgrang, the SEH fix still causes ARM64 COFF file crash when linking with CFG enabled (/guard:cf). Seems functions are not marked as IMAGE_SYM_DTYPE_FUNCTION in ARM64 COFF which was done in both x86 and arm32 COFF (see below 2 links).
>
> https://github.com/llvm-mirror/llvm/blob/2cc0a7da876c1d8c32775b0119e1e15aaa759b9e/lib/Target/X86/X86AsmPrinter.cpp#L67
>
> https://github.com/llvm-mirror/llvm/blob/2cc0a7da876c1d8c32775b0119e1e15aaa759b9e/lib/Target/ARM/ARMAsmPrinter.cpp#L148


Thanks @tomtan. I have a fix here: https://reviews.llvm.org/D55535


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53540/new/

https://reviews.llvm.org/D53540