[PATCH] D55396: [DebugInfo] Make sure CodeGenPrepare does not drop MD references to locals.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 10 17:09:30 PST 2018


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

LGTM with outstanding comment addressed.



================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:2396
       }
+      // Reinstate the original debug uses.
+      for (auto *DVI: DbgValues) {
----------------
Could you perhaps also add why reinstating is the right thing to do into the comment? Otherwise this will look confusing to future readers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55396/new/

https://reviews.llvm.org/D55396





More information about the llvm-commits mailing list