[PATCH] D55167: Add a new interceptors for cdbr(3) and cdbw(3) API from NetBSD

[Joerg Sonnenberger via Phabricator via llvm-commits]

joerg added a comment.

In D55167#1326120 <https://reviews.llvm.org/D55167#1326120>, @vitalybuka wrote:

> In D55167#1324855 <https://reviews.llvm.org/D55167#1324855>, @joerg wrote:
>
> > I don't see why this interceptor needs to know about the internals of `struct cdbr` or `struct cdbw` at all. They are fully opaque. All memory accessed by users is explicitly sized as argument to the functions or returned with the size.
>
>
> Then we give up on TSAN check of fieds, or msan check if caller will try to read particular fields


As I said, the structures are fully opaque. The only defined interface is through the functions already wrapped. For the reader interface, TSAN doesn't make sense as idempotent beyond creation and destruction. For the writer, the only useful check for TSAN would be to rule out two threads using the same instance. That shouldn't require any access to the internals though.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55167/new/

https://reviews.llvm.org/D55167