[PATCH] D55515: [x86] increment/decrement constant vector with min/max in vsetcc lowering (PR39859)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 10 14:49:01 PST 2018


spatel added a comment.

In D55515#1326183 <https://reviews.llvm.org/D55515#1326183>, @nikic wrote:

> Are there any tests for the 0/max cases? (I guess they're probably just constant folded away anyway?)


No - I can add those, but it's probably hard to get that pattern this deep into SDAG. 
And yes, we would hope that those would always get folded, but nothing is certain in SDAG which is why I could not just assert that those cases are impossible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55515/new/

https://reviews.llvm.org/D55515





More information about the llvm-commits mailing list