[PATCH] D55401: [WebAssembly] Fix assembler parsing of br_table.

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCCodeEmitter.cpp:97
       if (i < Desc.getNumOperands()) {
-        assert(Desc.TSFlags == 0 &&
+        assert((Desc.TSFlags == 0 || IsBrTable) &&
                "WebAssembly non-variable_ops don't use TSFlags");
----------------
aardappel wrote:
> dschuff wrote:
> > aardappel wrote:
> > > This is pretty yucky. I must I don't quite follow what these flags are used for, so not sure if we should remove these flags from br_table in the tablegen defs instead?
> > I think we can remove the flags from br_table in tablegen because it doesn't use variable_ops anymore. I think they are only used for determining how the variable_ops should be printed.
> variable_ops are still being used in call, but that doesn't print these either.
> 
> Want me to remove these flags as part of this CL or a next one?
Might be a bit cleaner to be in this one but I don't have a strong opinion.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55401/new/

https://reviews.llvm.org/D55401