[PATCH] D55467: [WebAssembly] Optimize Irreducible Control Flow

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyFixIrreducibleControlFlow.cpp:264
+  // Sort the entries to ensure a deterministic build.
+  std::sort(SortedEntries.begin(), SortedEntries.end(),
+            [&](const MachineBasicBlock *A, const MachineBasicBlock *B) {
----------------
Please use the range-based llvm::sort instead of std::sort.

```
llvm::sort(SortedEntries, comparator);
```

See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55467/new/

https://reviews.llvm.org/D55467