[PATCH] D54740: [NewPM] fixing asserts on deleted loop in -print-after-all

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

In D54740#1326123 <https://reviews.llvm.org/D54740#1326123>, @philip.pfaffe wrote:

> The IRUnit is invalid, but the handle still exists, right?


Invalid handle might be totally invalid, you can not use it for anything.
I do remember having accesses to freed memory when accessing either Loop or SCC, dont remember which one.
Even looking at the address might be not that sane if it was freed and perhaps something else allocated at that place.

Anyway, my point is that we do not have a well established notion of invalid IR.
And solution that tries to put order into pass-instrumentation handling of invalid IR first
needs to put order into overall handling of that invalid IR.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54740/new/

https://reviews.llvm.org/D54740