[PATCH] D54951: Implement a small subset of the C++ `type_traits` header inside sanitizer_common so we can avoid depending on system C++ headers.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 10 13:39:25 PST 2018


delcypher added a comment.

In D54951#1325854 <https://reviews.llvm.org/D54951#1325854>, @vitalybuka wrote:

> > @cryptoad 
> >  I'd like to still land it if possible. I intend to use this in future patches. I removed it from https://reviews.llvm.org/D54904 to simply have less code to review. My intention is to land this and then add the `static_assert(...)` that I wanted to write original in a future patch.
>
> Then we can review it with dependent patch?
>  There is probability that dependent patch will be changed during review or other reasons and we stuck with small but unused piece of code.


Okay. I'll merge this patch back into https://reviews.llvm.org/D54904?id=175500


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54951/new/

https://reviews.llvm.org/D54951





More information about the llvm-commits mailing list