[PATCH] D52999: [FileCheck] Annotate input dump (1/7)

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 10 13:34:42 PST 2018


probinson accepted this revision.
probinson added a comment.

I like having the extra explanations at the end of the tilde lines, that's a great idea.
One unnecessary include left, and LGTM.



================
Comment at: llvm/include/llvm/Support/FileCheck.h:21
 #include "llvm/Support/SourceMgr.h"
+#include <list>
 #include <vector>
----------------
I believe you don't need `<list>` anymore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52999/new/

https://reviews.llvm.org/D52999





More information about the llvm-commits mailing list