[PATCH] D55294: [GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs

[Volkan Keles via Phabricator via llvm-commits]

volkan added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h:110
+public:
+  enum SrcType { Ty_Reg, Ty_MIB };
+  SrcOp(unsigned R) : Reg(R), Ty(SrcType::Ty_Reg) {}
----------------
bogner wrote:
> Same comments as on DstType
Could you add support for CmpInst::Predicate as well? It would be easier to build a G_ICMP/G_FCMP using that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55294/new/

https://reviews.llvm.org/D55294