[PATCH] D54674: [llvm-objcopy] First bits for MachO

Mon Dec 10 10:56:10 PST 2018

rupprecht added a comment.

In D54674#1325009 <https://reviews.llvm.org/D54674#1325009>, @plotfi wrote:

> In D54674#1322482 <https://reviews.llvm.org/D54674#1322482>, @lhames wrote:
>
> > Apart from these specific comments, my general thought is that this is fine as far as it goes, but as it grows more fully featured it seems likely to start overlapping more libObject and MC functionality.
> >
> > Have you considered ways to refactor libObject/MC to allow objcopy to be built on top of them?
>

It's been suggested before (https://lists.llvm.org/pipermail/llvm-dev/2018-October/126661.html), but no concrete proposals have been put forward AFAIK.
With this and D54939 <https://reviews.llvm.org/D54939>, llvm-objcopy is about to go from ELF to ELF+MachO+COFF. IMO, we shouldn't block either of these patches on that idea, but we should start moving bits from llvm-objcopy into libObject soon after landing both:

1. Landing these patches sooner will give people more time to play around with MachO/COFF support in the tool (ELF support is fairly well known)
2. Being able to refactor things once all three object formats are in will help motivate the design (i.e. won't be an ELF-centric design)

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54674/new/

https://reviews.llvm.org/D54674