[PATCH] D55045: Add a version of std::function that includes a few optimizations.

Eric Fiselier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 10 10:40:21 PST 2018


EricWF added a comment.

LGTM after addressing the inline comments. We can further iterate after landing this if needed.



================
Comment at: include/functional:2311
+    {
+        return __invoker_.__call_(&__buf_,
+                                  _VSTD::forward<_ArgTypes>(__args)...);
----------------
`std::addressof` just in case?


================
Comment at: include/functional:2324
+    _LIBCPP_INLINE_VISIBILITY
+    _LIBCPP_EXPLICIT operator bool() const _NOEXCEPT
+    {
----------------
s/_LIBCPP_EXPLICIT/explicit




Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55045/new/

https://reviews.llvm.org/D55045





More information about the llvm-commits mailing list