[PATCH] D54951: Implement a small subset of the C++ `type_traits` header inside sanitizer_common so we can avoid depending on system C++ headers.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 10 10:32:27 PST 2018


delcypher added a comment.

In D54951#1325415 <https://reviews.llvm.org/D54951#1325415>, @cryptoad wrote:

> In D54951#1325058 <https://reviews.llvm.org/D54951#1325058>, @vitalybuka wrote:
>
> > I don't see it in D54904 <https://reviews.llvm.org/D54904>
>
>
> It was removed after https://reviews.llvm.org/D54904?id=175500.
>  Is this patch still necessary?


@cryptoad 
I'd like to still land it if possible. I intend to use this in future patches. I removed it from https://reviews.llvm.org/D54904 to simply have less code to review. My intention is to land this and then add the `static_assert(...)` that I wanted to write original in a future patch.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54951/new/

https://reviews.llvm.org/D54951





More information about the llvm-commits mailing list