[PATCH] D54904: Introduce `AddressSpaceView` template parameter to `SizeClassAllocator32`, `FlatByteMap`, and `TwoLevelByteMap`.

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

In D54904#1325056 <https://reviews.llvm.org/D54904#1325056>, @vitalybuka wrote:

> LGTM
>  but PrimaryAllocatorASVT is unused here, should we expect patches with PrimaryAllocatorASVT?


@vitalybuka 
Yes there will be patches that will use `PrimaryAllocatorASVT`. However I should note that we actually only need to support the `AddressSpaceView` template parameter not being `LocalAddressSpaceView` for ASan and LSan. For the other sanitizer allocators (e.g. TSan) would could have slightly simpler code that just hard codes using `LocalAddressSpaceView` rather than making it possible at compile time to change this. I didn't do this because I wanted to make the change uniformly to all the sanitizers. If you'd prefer that I make the changes to all the other sanitizers (i.e. not ASan and LSan) in a different way (i.e. hardcode `LocalAddressSpaceView`) then please let me know and I'll redo this patch.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54904/new/

https://reviews.llvm.org/D54904