[PATCH] D55241: AMDGPU: Should always start from the first register in VGPR indexing.

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 10 10:18:43 PST 2018


cfang added a comment.

In D55241#1323977 <https://reviews.llvm.org/D55241#1323977>, @arsenm wrote:

> No, it's not committed. Variable + constant is a common case in general.
>
> It would probably be better to do this fold in the DAG for now though


How can you guarantee, at machine instruction level, the base is non-negative even though you do this fold in the DAG?
Something may happen in between.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55241/new/

https://reviews.llvm.org/D55241





More information about the llvm-commits mailing list