[PATCH] D55515: [x86] increment/decrement constant vector with min/max in vsetcc lowering (PR39859)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 10 09:10:40 PST 2018


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:19394
+    // TODO: This could be extended to handle a non-splat constant by checking
+    // that each element of the constant is not the max/null value.
+    APInt C;
----------------
Can you use ISD::matchUnaryPredicate and get this TODO done straightaway?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55515/new/

https://reviews.llvm.org/D55515





More information about the llvm-commits mailing list