[PATCH] D38028: [X86][TableGen] Recommitting the X86 memory folding tables TableGen backend while disabling it by default.
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 10 08:26:06 PST 2018
thakis added a comment.
> Up to the folks using it :-) Out of curiosity, when you do this checking, do you manually run tablegen, or do you set this cmake var somehow?
Looks like just passing `-DX86_GEN_FOLD_TABLES=ON` to cmake is enough, so I'm guessing that's what you do.
But if y'all basically invoke this manually and then copy bits over, maybe you run `llvm-tblgen -gen-x86-fold-tables` directly? In that case, we could remove the (to me confusing) 4 lines of cmake? (I don't have a strong opinion about this; if you do invoke this via cmake I don't have a problem with keeping it in.)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D38028/new/
https://reviews.llvm.org/D38028
More information about the llvm-commits
mailing list