[PATCH] D55507: [DAGCombiner] Use the result value type in visitCONCAT_VECTORS

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.

I only have one comment. Otherwise, this LGTM. Thanks.

Please add your test case to the already existing `combine-concatvectors.ll`.



================
Comment at: test/CodeGen/X86/combine-concat-vectors.ll:1
+; RUN: llc -mtriple=x86_64-- -o - | FileCheck %s
+; Check that this does not fail to combine concat_vectors of a value from
----------------
You mean:

```; RUN: llc -mtriple=x86_64-- < %s | FileCheck %s```

That being said, there is already combine-concatvectors.ll. Your new test case should be added there.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55507/new/

https://reviews.llvm.org/D55507