[PATCH] D55414: [X86] Emit SBB instead of SETCC_CARRY from LowerSELECT. Break false dependency on the SBB input.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 10 04:13:42 PST 2018
RKSimon added inline comments.
================
Comment at: test/CodeGen/X86/pr35972.ll:10
; CHECK-NEXT: cmpl $1, {{[0-9]+}}(%esp)
; CHECK-NEXT: sbbl %ecx, %ecx
; CHECK-NEXT: kmovd %ecx, %k0
----------------
Now that the scheduler models are getting better at providing info on target-specific dependency breaking instructions, maybe a later pass should just cleanup things like this? I REALLY don't want yet another feature flag for this kind of thing.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55414/new/
https://reviews.llvm.org/D55414
More information about the llvm-commits
mailing list